Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slack ping action version reference #3651

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Fix slack ping action version reference #3651

merged 1 commit into from
Jan 10, 2024

Conversation

sarayourfriend
Copy link
Collaborator

Fixes

#3577 added new usages of slackapi/slack-github-action, but we missed that the version format was incorrect. The tags on the repository have v at the front, so we need to use them in the action version reference as well. You can compare this to other usages of the same action in our repository that have the correct format.

Here's an example of the broken code failing: https://github.com/WordPress/openverse/actions/runs/7470300640/job/20328836725?pr=3650

Testing Instructions

Compare to other usages of the action and make sure I've got the fix correct.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • [N/A] I added or updated documentation (if applicable).
  • [N/A] I tried running the project locally and verified that there are no visible errors.
  • [N/A] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: mgmt Related to repo management and automations labels Jan 10, 2024
@sarayourfriend sarayourfriend marked this pull request as ready for review January 10, 2024 04:31
@sarayourfriend sarayourfriend requested a review from a team as a code owner January 10, 2024 04:31
stacimc
stacimc approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@stacimc stacimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sarayourfriend sarayourfriend merged commit c2b9750 into main Jan 10, 2024
65 of 67 checks passed
@sarayourfriend sarayourfriend deleted the fix/slack-ping-action branch January 10, 2024 22:45
@krysal krysal mentioned this pull request Jan 11, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stacimc stacimc stacimc approved these changes

@krysal krysal krysal approved these changes

@fcoveram fcoveram Awaiting requested review from fcoveram fcoveram is a code owner automatically assigned from WordPress/openverse-maintainers

Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: mgmt Related to repo management and automations
Projects
Openverse PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarayourfriend @krysal @stacimc